Skip to content

Commit

Permalink
NCR53C8XX: Remove deprecated IRQ flags (SA_*)
Browse files Browse the repository at this point in the history
Stop using deprecated IRQ flags in ncr53c8xx documentaion.  The new IRQF_*
macros are used instead.

Signed-off-by: Ahmed S. Darwish <[email protected]>
Cc: James Bottomley <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
a-darwish authored and Linus Torvalds committed Oct 17, 2007
1 parent 96fdc72 commit 38d090b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions Documentation/scsi/ChangeLog.ncr53c8xx
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ Sun Feb 14:00 1999 Gerard Roudier ([email protected])
Pointed out by Leonard Zubkoff.
- Allow to tune request_irq() flags from the boot command line using
ncr53c8xx=irqm:??, as follows:
a) If bit 0x10 is set in irqm, SA_SHIRQ flag is not used.
b) If bit 0x20 is set in irqm, SA_INTERRUPT flag is not used.
By default the driver uses both SA_SHIRQ and SA_INTERRUPT.
a) If bit 0x10 is set in irqm, IRQF_SHARED flag is not used.
b) If bit 0x20 is set in irqm, IRQF_DISABLED flag is not used.
By default the driver uses both IRQF_SHARED and IRQF_DISABLED.
Option 'ncr53c8xx=irqm:0x20' may be used when an IRQ is shared by
a 53C8XX adapter and a network board.
- Tiny mispelling fixed (ABORT instead of ABRT). Was fortunately
Expand Down
14 changes: 7 additions & 7 deletions Documentation/scsi/ncr53c8xx.txt
Original file line number Diff line number Diff line change
Expand Up @@ -785,8 +785,8 @@ port address 0x1400.
irqm:0 always open drain
irqm:1 same as initial settings (assumed BIOS settings)
irqm:2 always totem pole
irqm:0x10 driver will not use SA_SHIRQ flag when requesting irq
irqm:0x20 driver will not use SA_INTERRUPT flag when requesting irq
irqm:0x10 driver will not use IRQF_SHARED flag when requesting irq
irqm:0x20 driver will not use IRQF_DISABLED flag when requesting irq

(Bits 0x10 and 0x20 can be combined with hardware irq mode option)

Expand Down Expand Up @@ -1236,23 +1236,23 @@ when the SCSI DATA IN phase is reentered after a phase mismatch.
When an IRQ is shared by devices that are handled by different drivers, it
may happen that one driver complains about the request of the IRQ having
failed. Inder Linux-2.0, this may be due to one driver having requested the
IRQ using the SA_INTERRUPT flag but some other having requested the same IRQ
IRQ using the IRQF_DISABLED flag but some other having requested the same IRQ
without this flag. Under both Linux-2.0 and linux-2.2, this may be caused by
one driver not having requested the IRQ with the SA_SHIRQ flag.
one driver not having requested the IRQ with the IRQF_SHARED flag.

By default, the ncr53c8xx and sym53c8xx drivers request IRQs with both the
SA_INTERRUPT and the SA_SHIRQ flag under Linux-2.0 and with only the SA_SHIRQ
IRQF_DISABLED and the IRQF_SHARED flag under Linux-2.0 and with only the IRQF_SHARED
flag under Linux-2.2.

Under Linux-2.0, you can disable use of SA_INTERRUPT flag from the boot
Under Linux-2.0, you can disable use of IRQF_DISABLED flag from the boot
command line by using the following option:

ncr53c8xx=irqm:0x20 (for the generic ncr53c8xx driver)
sym53c8xx=irqm:0x20 (for the sym53c8xx driver)

If this does not fix the problem, then you may want to check how all other
drivers are requesting the IRQ and report the problem. Note that if at least
a single driver does not request the IRQ with the SA_SHIRQ flag (share IRQ),
a single driver does not request the IRQ with the IRQF_SHARED flag (share IRQ),
then the request of the IRQ obviously will not succeed for all the drivers.

15. SCSI problem troubleshooting
Expand Down

0 comments on commit 38d090b

Please sign in to comment.