Skip to content

Commit

Permalink
mfd: max77693: Use proper regmap for handling MUIC interrupts
Browse files Browse the repository at this point in the history
Interrupts coming from Maxim77693 MUIC block (MicroUSB Interface
Controller) were not handled at all because wrong regmap was used for
MUIC's regmap_irq_chip.

The MUIC component of Maxim 77693 uses different I2C address thus second
regmap is created and used by max77693 extcon driver. The registers for
MUIC interrupts are also in that block and should be handled by that
second regmap.

However the regmap irq chip for MUIC was configured with default regmap
which could not read MUIC registers.

Fixes: 342d669 ("mfd: max77693: Handle IRQs using regmap")

Cc: <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Chanwoo Choi <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
krzk authored and Lee Jones committed Nov 10, 2014
1 parent b668422 commit 43fc939
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mfd/max77693.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
goto err_irq_charger;
}

ret = regmap_add_irq_chip(max77693->regmap, max77693->irq,
ret = regmap_add_irq_chip(max77693->regmap_muic, max77693->irq,
IRQF_ONESHOT | IRQF_SHARED |
IRQF_TRIGGER_FALLING, 0,
&max77693_muic_irq_chip,
Expand Down

0 comments on commit 43fc939

Please sign in to comment.