Skip to content

Commit

Permalink
[media] omap3isp: Replace printk with dev_*
Browse files Browse the repository at this point in the history
Use the dev_* message logging API instead of raw printk.

Signed-off-by: Laurent Pinchart <[email protected]>
Acked-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
pinchartl authored and Mauro Carvalho Chehab committed Nov 28, 2012
1 parent aab84f5 commit 4feca39
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 11 deletions.
12 changes: 6 additions & 6 deletions drivers/media/platform/omap3isp/isp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,7 @@ isp_register_subdev_group(struct isp_device *isp,

adapter = i2c_get_adapter(board_info->i2c_adapter_id);
if (adapter == NULL) {
printk(KERN_ERR "%s: Unable to get I2C adapter %d for "
dev_err(isp->dev, "%s: Unable to get I2C adapter %d for "
"device %s\n", __func__,
board_info->i2c_adapter_id,
board_info->board_info->type);
Expand All @@ -1689,7 +1689,7 @@ isp_register_subdev_group(struct isp_device *isp,
subdev = v4l2_i2c_new_subdev_board(&isp->v4l2_dev, adapter,
board_info->board_info, NULL);
if (subdev == NULL) {
printk(KERN_ERR "%s: Unable to register subdev %s\n",
dev_err(isp->dev, "%s: Unable to register subdev %s\n",
__func__, board_info->board_info->type);
continue;
}
Expand All @@ -1714,15 +1714,15 @@ static int isp_register_entities(struct isp_device *isp)
isp->media_dev.link_notify = isp_pipeline_link_notify;
ret = media_device_register(&isp->media_dev);
if (ret < 0) {
printk(KERN_ERR "%s: Media device registration failed (%d)\n",
dev_err(isp->dev, "%s: Media device registration failed (%d)\n",
__func__, ret);
return ret;
}

isp->v4l2_dev.mdev = &isp->media_dev;
ret = v4l2_device_register(isp->dev, &isp->v4l2_dev);
if (ret < 0) {
printk(KERN_ERR "%s: V4L2 device registration failed (%d)\n",
dev_err(isp->dev, "%s: V4L2 device registration failed (%d)\n",
__func__, ret);
goto done;
}
Expand Down Expand Up @@ -1809,8 +1809,8 @@ static int isp_register_entities(struct isp_device *isp)
break;

default:
printk(KERN_ERR "%s: invalid interface type %u\n",
__func__, subdevs->interface);
dev_err(isp->dev, "%s: invalid interface type %u\n",
__func__, subdevs->interface);
ret = -EINVAL;
goto done;
}
Expand Down
6 changes: 3 additions & 3 deletions drivers/media/platform/omap3isp/ispcsi2.c
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ int omap3isp_csi2_reset(struct isp_csi2_device *csi2)
} while (soft_reset_retries < 5);

if (soft_reset_retries == 5) {
printk(KERN_ERR "CSI2: Soft reset try count exceeded!\n");
dev_err(isp->dev, "CSI2: Soft reset try count exceeded!\n");
return -EBUSY;
}

Expand All @@ -535,8 +535,8 @@ int omap3isp_csi2_reset(struct isp_csi2_device *csi2)
} while (--i > 0);

if (i == 0) {
printk(KERN_ERR
"CSI2: Reset for CSI2_96M_FCLK domain Failed!\n");
dev_err(isp->dev,
"CSI2: Reset for CSI2_96M_FCLK domain Failed!\n");
return -EBUSY;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/platform/omap3isp/ispcsiphy.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static int csiphy_set_power(struct isp_csiphy *phy, u32 power)
} while ((reg != power >> 2) && (retry_count < 100));

if (retry_count == 100) {
printk(KERN_ERR "CSI2 CIO set power failed!\n");
dev_err(phy->isp->dev, "CSI2 CIO set power failed!\n");
return -EBUSY;
}

Expand Down
3 changes: 2 additions & 1 deletion drivers/media/platform/omap3isp/ispvideo.c
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,8 @@ int omap3isp_video_register(struct isp_video *video, struct v4l2_device *vdev)

ret = video_register_device(&video->video, VFL_TYPE_GRABBER, -1);
if (ret < 0)
printk(KERN_ERR "%s: could not register video device (%d)\n",
dev_err(video->isp->dev,
"%s: could not register video device (%d)\n",
__func__, ret);

return ret;
Expand Down

0 comments on commit 4feca39

Please sign in to comment.