Skip to content

Commit

Permalink
getdelays.c: fix overrun
Browse files Browse the repository at this point in the history
A patch for getdelays.c that fixes a buffer overrun when you set -w.

Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Scott Wiersdorf authored and Linus Torvalds committed May 8, 2007
1 parent d1ab824 commit 7f76c40
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Documentation/accounting/getdelays.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ __u64 stime, utime;
#define MAX_MSG_SIZE 1024
/* Maximum number of cpus expected to be specified in a cpumask */
#define MAX_CPUS 32
/* Maximum length of pathname to log file */
#define MAX_FILENAME 256

struct msgtemplate {
struct nlmsghdr n;
Expand Down Expand Up @@ -231,7 +229,7 @@ int main(int argc, char *argv[])
int count = 0;
int write_file = 0;
int maskset = 0;
char logfile[128];
char *logfile = NULL;
int loop = 0;

struct msgtemplate msg;
Expand All @@ -251,7 +249,7 @@ int main(int argc, char *argv[])
print_io_accounting = 1;
break;
case 'w':
strncpy(logfile, optarg, MAX_FILENAME);
logfile = strdup(optarg);
printf("write to file %s\n", logfile);
write_file = 1;
break;
Expand Down

0 comments on commit 7f76c40

Please sign in to comment.