Skip to content

Commit

Permalink
powerpc: Fix section mismatch warning in free_lppacas
Browse files Browse the repository at this point in the history
While cross-building for PPC64 I've got bunch of

WARNING: arch/powerpc/kernel/built-in.o(.text.unlikely+0x2d2): Section
mismatch in reference from the function .free_lppacas() to the variable
.init.data:lppaca_size The function .free_lppacas() references the variable
__initdata lppaca_size. This is often because .free_lppacas lacks a __initdata
annotation or the annotation of lppaca_size is wrong.

Fix it by using proper annotation for free_lppacas. Additionally, annotate
{allocate,new}_llpcas properly.

Signed-off-by: Vladimir Murzin <[email protected]>
Acked-by: Michael Ellerman <[email protected]>
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
  • Loading branch information
murzinv authored and ozbenh committed Oct 11, 2013
1 parent 0edfdd1 commit 8616dff
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/powerpc/kernel/paca.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ struct lppaca lppaca[] = {
static struct lppaca *extra_lppacas;
static long __initdata lppaca_size;

static void allocate_lppacas(int nr_cpus, unsigned long limit)
static void __init allocate_lppacas(int nr_cpus, unsigned long limit)
{
if (nr_cpus <= NR_LPPACAS)
return;
Expand All @@ -57,7 +57,7 @@ static void allocate_lppacas(int nr_cpus, unsigned long limit)
PAGE_SIZE, limit));
}

static struct lppaca *new_lppaca(int cpu)
static struct lppaca * __init new_lppaca(int cpu)
{
struct lppaca *lp;

Expand All @@ -70,7 +70,7 @@ static struct lppaca *new_lppaca(int cpu)
return lp;
}

static void free_lppacas(void)
static void __init free_lppacas(void)
{
long new_size = 0, nr;

Expand Down

0 comments on commit 8616dff

Please sign in to comment.