Skip to content

Commit

Permalink
cio: remove {get,put}_driver
Browse files Browse the repository at this point in the history
Remove useless {get,put}_driver - the caller of the functions
has to ensure valid driver pointers.

Signed-off-by: Sebastian Ott <[email protected]>
Signed-off-by: Alan Stern <[email protected]>
CC: Martin Schwidefsky <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Sebastian Ott authored and gregkh committed Jan 25, 2012
1 parent cef9bc5 commit 9f30ea9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 0 additions & 2 deletions drivers/s390/cio/ccwgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,6 @@ void ccwgroup_driver_unregister(struct ccwgroup_driver *cdriver)
struct device *dev;

/* We don't want ccwgroup devices to live longer than their driver. */
get_driver(&cdriver->driver);
while ((dev = driver_find_device(&cdriver->driver, NULL, NULL,
__ccwgroup_match_all))) {
struct ccwgroup_device *gdev = to_ccwgroupdev(dev);
Expand All @@ -592,7 +591,6 @@ void ccwgroup_driver_unregister(struct ccwgroup_driver *cdriver)
mutex_unlock(&gdev->reg_mutex);
put_device(dev);
}
put_driver(&cdriver->driver);
driver_unregister(&cdriver->driver);
}
EXPORT_SYMBOL(ccwgroup_driver_unregister);
Expand Down
8 changes: 1 addition & 7 deletions drivers/s390/cio/device.c
Original file line number Diff line number Diff line change
Expand Up @@ -1676,15 +1676,9 @@ struct ccw_device *get_ccwdev_by_busid(struct ccw_driver *cdrv,
const char *bus_id)
{
struct device *dev;
struct device_driver *drv;

drv = get_driver(&cdrv->driver);
if (!drv)
return NULL;

dev = driver_find_device(drv, NULL, (void *)bus_id,
dev = driver_find_device(&cdrv->driver, NULL, (void *)bus_id,
__ccwdev_check_busid);
put_driver(drv);

return dev ? to_ccwdev(dev) : NULL;
}
Expand Down

0 comments on commit 9f30ea9

Please sign in to comment.