Skip to content

Commit

Permalink
watchdog: imgpdc: Fix default heartbeat
Browse files Browse the repository at this point in the history
The IMG PDC watchdog driver heartbeat module parameter has no default so
it is initialised to zero. This results in the following warning during
probe:

imgpdc-wdt 2006000.wdt: Initial timeout out of range! setting max timeout

The module parameter description implies that the default value should
be PDC_WDT_DEF_TIMEOUT, which isn't yet used, so initialise it to that.

Also tweak the heartbeat module parameter description for consistency.

Fixes: 9393766 ("watchdog: ImgTec PDC Watchdog Timer Driver")
Signed-off-by: James Hogan <[email protected]>
Cc: Ezequiel Garcia <[email protected]>
Cc: Naidu Tellapati <[email protected]>
Cc: Jude Abraham <[email protected]>
Cc: [email protected]
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>
  • Loading branch information
James Hogan authored and Wim Van Sebroeck committed Mar 27, 2015
1 parent a629c08 commit ae6ee2f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/watchdog/imgpdc_wdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
#define PDC_WDT_MIN_TIMEOUT 1
#define PDC_WDT_DEF_TIMEOUT 64

static int heartbeat;
static int heartbeat = PDC_WDT_DEF_TIMEOUT;
module_param(heartbeat, int, 0);
MODULE_PARM_DESC(heartbeat, "Watchdog heartbeats in seconds. "
"(default = " __MODULE_STRING(PDC_WDT_DEF_TIMEOUT) ")");
MODULE_PARM_DESC(heartbeat, "Watchdog heartbeats in seconds "
"(default=" __MODULE_STRING(PDC_WDT_DEF_TIMEOUT) ")");

static bool nowayout = WATCHDOG_NOWAYOUT;
module_param(nowayout, bool, 0);
Expand Down

0 comments on commit ae6ee2f

Please sign in to comment.