Skip to content

Commit

Permalink
[SCSI] qla2xxx: Double check for command completion if abort mailbox …
Browse files Browse the repository at this point in the history
…command fails.

Close a small window where we could falsely fail an abort request if the mailbox
command fails but the command was returned during interrupt context.

Signed-off-by: Chad Dupuis <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
Chad Dupuis authored and James Bottomley committed Aug 27, 2011
1 parent 7594206 commit bc91ade
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/scsi/qla2xxx/qla_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@ qla2xxx_eh_abort(struct scsi_cmnd *cmd)
qla2x00_sp_compl(ha, sp);
spin_unlock_irqrestore(&ha->hardware_lock, flags);

/* Did the command return during mailbox execution? */
if (ret == FAILED && !CMD_SP(cmd))
ret = SUCCESS;

/* Wait for the command to be returned. */
if (wait) {
if (qla2x00_eh_wait_on_command(cmd) != QLA_SUCCESS) {
Expand Down

0 comments on commit bc91ade

Please sign in to comment.