tcp: fix a panic on UP machines in reqsk_fastopen_remove

spin_is_locked() on a non !SMP build is kind of useless. BUG_ON(!spin_is_locked(xx)) is guaranteed to crash. Just remove this check in reqsk_fastopen_remove() as the callers do hold the socket lock. Reported-by: Ketan Kulkarni <[email protected]> Signed-off-by: Eric Dumazet <[email protected]> Cc: Jerry Chu <[email protected]> Cc: Yuchung Cheng <[email protected]> Cc: Dave Taht <[email protected]> Acked-by: H.K. Jerry Chu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
cbmeeks · Jan 14, 2013 · cce894b · cce894b
1 parent 3152ba0
commit cce894b
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/net/core/request_sock.c b/net/core/request_sock.c
@@ -186,8 +186,6 @@ void reqsk_fastopen_remove(struct sock *sk, struct request_sock *req,
 	struct fastopen_queue *fastopenq =
 	    inet_csk(lsk)->icsk_accept_queue.fastopenq;
 
-	BUG_ON(!spin_is_locked(&sk->sk_lock.slock) && !sock_owned_by_user(sk));
-
 	tcp_sk(sk)->fastopen_rsk = NULL;
 	spin_lock_bh(&fastopenq->lock);
 	fastopenq->qlen--;