Skip to content

Commit

Permalink
panic: Fix panic message visibility by calling bust_spinlocks(0) befo…
Browse files Browse the repository at this point in the history
…re dying

Commit ffd71da ("panic: decrease oops_in_progress only after
having done the panic") moved bust_spinlocks(0) to the end of the
function, which in practice is never reached.

As a result console_unblank() is not called, and on some systems
the user may not see the panic message.

Move it back up to before the unblanking.

Signed-off-by: Aaro Koskinen <[email protected]>
Reviewed-by: Frederic Weisbecker <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
aakoskin authored and Ingo Molnar committed Oct 5, 2009
1 parent 135c8ae commit d014e88
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kernel/panic.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)

atomic_notifier_call_chain(&panic_notifier_list, 0, buf);

bust_spinlocks(0);

if (!panic_blink)
panic_blink = no_blink;

Expand Down Expand Up @@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
mdelay(1);
i++;
}
bust_spinlocks(0);
}

EXPORT_SYMBOL(panic);
Expand Down

0 comments on commit d014e88

Please sign in to comment.