trace_stack: Fix seqfile memory leak

Every time we cat stack_trace, we leak memory allocated by seq_open(). Signed-off-by: Li Zefan <[email protected]> LKML-Reference: <[email protected]> Signed-off-by: Steven Rostedt <[email protected]>
cbmeeks · Jul 23, 2009 · d8cc1ab · d8cc1ab
1 parent e5d490b
commit d8cc1ab
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
@@ -301,17 +301,14 @@ static const struct seq_operations stack_trace_seq_ops = {
 
 static int stack_trace_open(struct inode *inode, struct file *file)
 {
-	int ret;
-
-	ret = seq_open(file, &stack_trace_seq_ops);
-
-	return ret;
+	return seq_open(file, &stack_trace_seq_ops);
 }
 
 static const struct file_operations stack_trace_fops = {
 	.open		= stack_trace_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
+	.release	= seq_release,
 };
 
 int