Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated load() #78

Merged
merged 2 commits into from
Jul 31, 2016
Merged

Replace deprecated load() #78

merged 2 commits into from
Jul 31, 2016

Conversation

lbausch
Copy link
Contributor

@lbausch lbausch commented Jul 30, 2016

This PR replaces load() which is deprecated since version 1.8 of jQuery.

This PR replaces load() which is [deprecated](http://api.jquery.com/load-event/) since version 1.8 of jQuery.
@@ -549,7 +549,7 @@
break;
default:
if (_self.objectData.url) {
$object.load(function () {
$object.on('load', function() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbausch Thanks a lot for this pull request!
Just one thing: Anonymous functions are strictly witten with a space between function () in lightcase.

@cbopp-art cbopp-art merged commit d4eca7c into cbopp-art:master Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants