Add slack channel to readme page (cadence-workflow#2426)

ccbond · Aug 22, 2019 · fc2d286 · fc2d286
1 parent b1ca506
commit fc2d286
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 18 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,7 @@
-# Cadence [![Build Status](https://badge.buildkite.com/159887afd42000f11126f85237317d4090de97b26c287ebc40.svg?theme=github&branch=master)](https://buildkite.com/uberopensource/cadence-server) [![Coverage Status](https://coveralls.io/repos/github/uber/cadence/badge.svg)](https://coveralls.io/github/uber/cadence)
+# Cadence 
+[![Build Status](https://badge.buildkite.com/159887afd42000f11126f85237317d4090de97b26c287ebc40.svg?theme=github&branch=master)](https://buildkite.com/uberopensource/cadence-server) 
+[![Coverage Status](https://coveralls.io/repos/github/uber/cadence/badge.svg)](https://coveralls.io/github/uber/cadence)
+[![Slack Status](https://img.shields.io/badge/slack-join_chat-white.svg?logo=slack&style=social)](https://app.slack.com/team/UFQ98VD0T)
 
 Cadence is a distributed, scalable, durable, and highly available orchestration engine we developed at Uber Engineering to execute asynchronous long-running business logic in a scalable and resilient way.
 

diff --git a/service/history/mutableStateBuilder.go b/service/history/mutableStateBuilder.go
@@ -4007,13 +4007,9 @@ func (e *mutableStateBuilder) closeTransactionHandleActivityUserTimerTasks(
 		return err
 	}
 
-	if err := e.taskGenerator.generateUserTimerTasks(
+	return e.taskGenerator.generateUserTimerTasks(
 		e.unixNanoToTime(now.UnixNano()),
-	); err != nil {
-		return err
-	}
-
-	return nil
+	)
 }
 
 func (e *mutableStateBuilder) prepareTransaction(
@@ -4058,14 +4054,10 @@ func (e *mutableStateBuilder) prepareTransaction(
 	//  since we only generate at most one activity & user timer,
 	//  regardless of how many activity & user timer created
 	//  so the calculation must be at the very end
-	if err := e.closeTransactionHandleActivityUserTimerTasks(
+	return e.closeTransactionHandleActivityUserTimerTasks(
 		now,
 		transactionPolicy,
-	); err != nil {
-		return err
-	}
-
-	return nil
+	)
 }
 
 func (e *mutableStateBuilder) cleanupTransaction(

diff --git a/service/history/mutableStateTaskRefresher.go b/service/history/mutableStateTaskRefresher.go
@@ -107,11 +107,7 @@ func (r *mutableStateTaskRefresherImpl) refreshTasks(now time.Time) error {
 		return err
 	}
 
-	if err := r.refreshTasksForWorkflowSearchAttr(now); err != nil {
-		return err
-	}
-
-	return nil
+	return r.refreshTasksForWorkflowSearchAttr(now)
 }
 
 func (r *mutableStateTaskRefresherImpl) refreshTasksForWorkflowStart(

diff --git a/tools/cli/adminElasticSearchCommands.go b/tools/cli/adminElasticSearchCommands.go
@@ -205,6 +205,7 @@ func AdminIndex(c *cli.Context) {
 	}
 }
 
+// AdminDelete used to delete documents from ElasticSearch with input of list result
 func AdminDelete(c *cli.Context) {
 	esClient := getESClient(c)
 	indexName := getRequiredOption(c, FlagIndex)