[c++] Fixed virtual destructors (apache#2754)

ccf19881030 · Oct 10, 2018 · 8d396c3 · 8d396c3
1 parent 95f67d0
commit 8d396c3
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/pulsar-client-cpp/include/pulsar/CryptoKeyReader.h b/pulsar-client-cpp/include/pulsar/CryptoKeyReader.h
@@ -28,7 +28,7 @@ namespace pulsar {
 
 class CryptoKeyReader {
    public:
-    CryptoKeyReader() {}
+    virtual ~CryptoKeyReader() {}
 
     /*
      * Return the encryption key corresponding to the key name in the argument

diff --git a/pulsar-client-cpp/include/pulsar/Logger.h b/pulsar-client-cpp/include/pulsar/Logger.h
@@ -34,6 +34,8 @@ class Logger {
         ERROR = 3
     };
 
+    virtual ~Logger() {}
+
     virtual bool isEnabled(Level level) = 0;
 
     virtual void log(Level level, int line, const std::string& message) = 0;

diff --git a/pulsar-client-cpp/include/pulsar/TopicMetadata.h b/pulsar-client-cpp/include/pulsar/TopicMetadata.h
@@ -27,6 +27,8 @@ namespace pulsar {
  */
 class TopicMetadata {
    public:
+    virtual ~TopicMetadata() {}
+
     virtual int getNumPartitions() const = 0;
 };
 }  // namespace pulsar

diff --git a/pulsar-client-cpp/lib/Hash.h b/pulsar-client-cpp/lib/Hash.h
@@ -25,6 +25,8 @@
 namespace pulsar {
 class Hash {
    public:
+    virtual ~Hash() {}
+
     /**
      * Generate the hash of a given String
      *