Avoid NullPointerException in ZK server stats collection (apache#2710)

ccf19881030 · Oct 3, 2018 · fe04ce8 · fe04ce8
1 parent 1f37326
commit fe04ce8
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/pulsar-zookeeper/src/main/java/org/apache/pulsar/zookeeper/ZooKeeperServerAspect.java b/pulsar-zookeeper/src/main/java/org/apache/pulsar/zookeeper/ZooKeeperServerAspect.java
@@ -20,6 +20,7 @@
 
 import io.prometheus.client.Gauge;
 
+import org.apache.zookeeper.server.ServerCnxnFactory;
 import org.apache.zookeeper.server.ZooKeeperServer;
 import org.aspectj.lang.JoinPoint;
 import org.aspectj.lang.annotation.After;
@@ -71,7 +72,12 @@ public double get() {
                 .setChild(new Gauge.Child() {
                     @Override
                     public double get() {
-                        return zkServer.serverStats().getNumAliveClientConnections();
+                        ServerCnxnFactory cnxFactory = zkServer.getServerCnxnFactory();
+                        if (cnxFactory != null) {
+                            return cnxFactory.getNumAliveConnections();
+                        } else {
+                            return -1;
+                        }
                     }
                 }).register();