fix(gcds-textarea): Properly set value in shadow-root textarea #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
As mentioned in #685, the
gcds-textarea
value would not be properly reset when using Formgroup. After some investigation it was revealed this wasn't directly related to the Angular implementation ofgcds-textarea
and was just a bug within the web component.When the component's value changes, the value was not properly being transferred to the textarea in the shadow-root of the component so the shadow-root textarea would keep the previous value while the rest of the component would register the new value.
How to test
Code example
Instructions
Run through the instructions once on the
main
branch and then on this branch to see the fix.gcds-textarea
component.main
branch, the textarea will still show the typed text in the textarea but the character count will be reset. On this branch, the textarea should no longer show any text in the textarea.