Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Symfony YAML does not parse all YAML #223

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SOHELAHMED7
Copy link
Contributor

@SOHELAHMED7 SOHELAHMED7 commented Jan 27, 2025

Fixes #21


Note

This PR remove symfony/yaml package and use php-ext-yaml instead.
php-ext-yaml does not support YAML 1.2 and symfony/yaml does.

@SOHELAHMED7 SOHELAHMED7 changed the title Draft: Symfony YAML does not parse all YAML Resolve: Symfony YAML does not parse all YAML Feb 5, 2025
@SOHELAHMED7 SOHELAHMED7 marked this pull request as ready for review February 5, 2025 12:35
@cebe
Copy link
Owner

cebe commented Feb 7, 2025

I would not drop the library but rather make it possible to use both. I'd like to avoid requiring a PHP extension that is not in php core.

@SOHELAHMED7 SOHELAHMED7 marked this pull request as draft February 7, 2025 11:52
@SOHELAHMED7 SOHELAHMED7 changed the title Resolve: Symfony YAML does not parse all YAML Draft: Symfony YAML does not parse all YAML Feb 7, 2025
@SOHELAHMED7
Copy link
Contributor Author

This will not completely solve #21.

We can 'composer suggest' consumer of this lib to use php-ext-yaml.

If the extension is present we can use or else symfony/yaml.

How do I know given YML is in which version if %YAML directive is not present?

I am asking because extension does not support YAML 1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony YAML does not parse all YAML
2 participants