Skip to content

Commit

Permalink
docs: match docs for "network upgrade" (#205)
Browse files Browse the repository at this point in the history
* docs: match docs for "network upgrade"

* docs: fix other instances of hardfork -> breaking network upgrade
  • Loading branch information
jcstein authored Sep 17, 2024
1 parent 389ed24 commit b7ca0c9
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion cips/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Read [CIP-1](./cip-1.md) for information on the CIP process.
| [14](./cip-14.md) | ICS-27 Interchain Accounts | Susannah Evans <[email protected]> ([@womensrights](https://github.com/womensrights)), Aidan Salzmann <[email protected]> ([@asalzmann](https://github.com/asalzmann)), Sam Pochyly <[email protected]> ([@sampocs](https://github.com/sampocs)) |
| [15](./cip-15.md) | Discourage memo usage | Rootul Patel ([@rootulp](https://github.com/rootulp)), NashQueue ([@nashqueue](https://github.com/nashqueue)) |
| [16](./cip-16.md) | Make Security Related Governance Parameters Immutable | Mingpei CAO ([@caomingpei](https://github.com/caomingpei)) |
| [17](./cip-17.md) | Lemongrass Hardfork | Evan Forbes ([@evan-forbes](https://github.com/evan-forbes)) |
| [17](./cip-17.md) | Lemongrass Network Upgrade | Evan Forbes ([@evan-forbes](https://github.com/evan-forbes)) |
| [18](./cip-18.md) | Standardised Gas and Pricing Estimation Interface | Callum Waters ([@cmwaters](https://github.com/cmwaters)) |
| [19](./cip-19.md) | Shwap Protocol | Hlib Kanunnikov ([@Wondertan](https://github.com/Wondertan)) |
| [20](./cip-20.md) | Disable Blobstream module | Rootul Patel ([@rootulp](https://github.com/rootulp)) |
Expand Down
4 changes: 2 additions & 2 deletions cips/cip-13.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Furthermore, the motivation for adding on-chain governance parameters as a refer

## Specification

These are the parameters that are active on Celestia Mainnet. Note that not all of these parameters are changeable via on-chain governance. This list also includes parameter that require a hardfork to change due to being manually hardcoded in the application or they are blocked by the `x/paramfilter` module. The Celestia Mainnet on-chain governance parameters are as follows:
These are the parameters that are active on Celestia Mainnet. Note that not all of these parameters are changeable via on-chain governance. This list also includes parameter that require a breaking network upgrade to change due to being manually hardcoded in the application or they are blocked by the `x/paramfilter` module. The Celestia Mainnet on-chain governance parameters are as follows:

### Global parameters

Expand Down Expand Up @@ -91,7 +91,7 @@ This is the primary reason for recommending this document become a Living docume

## Backwards Compatibility

The proposed parameters are intended for the Mainnet and some of the parameters do require a hardfork, which introduces backward incompatibility after a network upgrade if one of those values needs to be changed.
The proposed parameters are intended for the Mainnet and some of the parameters do require a breaking network upgrade, which introduces backward incompatibility after a network upgrade if one of those values needs to be changed.

## Security Considerations

Expand Down
4 changes: 2 additions & 2 deletions cips/cip-16.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ In summary, configuring these two parameters as immutable values that can NOT be

## Backwards Compatibility

This CIP recommends freezing on-chain governance for two security related parameters, which introduces backward incompatibility. This incompatibility is due to any future modifications to these parameters requiring at least a hardfork.
This CIP recommends freezing on-chain governance for two security related parameters, which introduces backward incompatibility. This incompatibility is due to any future modifications to these parameters requiring at least a breaking network upgrade.

## Reference Implementation

Expand All @@ -88,7 +88,7 @@ Besides, relevant documents should be updated accordingly, such as [Celestia App

## Security Considerations

This CIP recommends setting those two parameters as immutable constants which are NOT allowed to change via on-chain governance proposals. Adopting this CIP means future changes for those two parameters require community coordination and hardforks. Although hardforks carry the community-divided risk, it is worth noting that many blockchain communities have successfully navigated multiple hardforks. The risks of division and disagreement can be minimized by thoroughly discussing and working towards widespread agreement before moving forward with a hardfork. Consequently, the risk is manageable and should not be a significant concern.
This CIP recommends setting those two parameters as immutable constants which are NOT allowed to change via on-chain governance proposals. Adopting this CIP means future changes for those two parameters require community coordination and breaking network upgrades. Although these upgrades carry the community-divided risk, it is worth noting that many blockchain communities have successfully navigated multiple breaking network upgrades. The risks of division and disagreement can be minimized by thoroughly discussing and working towards widespread agreement before moving forward with a breaking network upgrade. Consequently, the risk is manageable and should not be a significant concern.

If the proposed two parameters have not been changed since genesis, the security impact of making them NOT changeable via on-chain governance is not significant. Besides, if modifications to those two parameters via on-chain governance are still allowed, this could not only result in the inconsistency between the protocol and implementation but also introduce the following potential security risks:

Expand Down
6 changes: 3 additions & 3 deletions cips/cip-17.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
| cip | 17 |
| - | - |
| title | Lemongrass Hardfork |
| description | Reference specifications included in the Lemongrass Hardfork |
| title | Lemongrass Network Upgrade |
| description | Reference specifications included in the Lemongrass Network Upgrade |
| author | [@evan-forbes](https://github.com/evan-forbes) |
| discussions-to | <https://forum.celestia.org/t/lemongrass-hardfork/1589> |
| status | Final |
Expand All @@ -23,7 +23,7 @@ This Meta CIP lists the CIPs included in the Lemongrass network upgrade.
- [CIP-14](./cip-14.md): Interchain Accounts
- [CIP-20](./cip-20.md): Disable Blobstream module

All of the above CIPs are state breaking, and thus require a hardfork. The activation of this hardfork will be different from future hardforks, as described in [CIP-10](./cip-10.md).
All of the above CIPs are state breaking, and thus require a breaking network upgrade. The activation of this network upgrade will be different from future network upgrades, as described in [CIP-10](./cip-10.md).

## Rationale

Expand Down
2 changes: 1 addition & 1 deletion cips/notes/cdc-15.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* Celestia Node to release update supporting Celestia App v2 soon
* Arabica devnet upgrade planned for **August 14th**
* Node operators must upgrade within **1 week** timeframe
* Consensus node operators need to use a specific CLI flag ([see documentation](https://docs.celestia.org/nodes/hardfork-process#lemongrass-hardfork))
* Consensus node operators need to use a specific CLI flag ([see documentation](https://docs.celestia.org/nodes/network-upgrade-process#lemongrass-network-upgrade))
* **Application owners on Arabica advised to monitor before and after upgrade**
* Upgrade process: Arabica first, then Mocha, finally Mainnet

Expand Down

0 comments on commit b7ca0c9

Please sign in to comment.