Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve #11 #13

Closed
wants to merge 4 commits into from
Closed

chore: resolve #11 #13

wants to merge 4 commits into from

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Nov 16, 2023 •
edited
Loading

Overview

Resolves #11

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from cmwaters November 16, 2023 14:33
@jcstein jcstein requested a review from YazzyYaz November 16, 2023 14:34
@jcstein jcstein self-assigned this Nov 16, 2023
YazzyYaz
YazzyYaz suggested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@YazzyYaz YazzyYaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a ## CIPs section

@jcstein
Copy link
Member Author

jcstein commented Nov 21, 2023

could we maybe add a directory in a sub-page for ease of browsing the repo?

@jcstein jcstein changed the title chore: resolve #10 and #11 chore: resolve #11 Nov 21, 2023
@YazzyYaz
Copy link
Contributor

we also don't need files renamed. let's stick to cip-X please.

@jcstein jcstein closed this Nov 21, 2023
@jcstein jcstein deleted the jcs/updates branch November 21, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YazzyYaz YazzyYaz YazzyYaz requested changes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@jcstein jcstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File names should include both CIP number and title
2 participants
@jcstein @YazzyYaz