Fix issue with no-unused-vars

Override functions without parameter names were triggering a false positive.
celo-org · Jan 28, 2020 · 6551578 · 6551578
1 parent d20e850
commit 6551578
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/rules/best-practises/no-unused-vars.js b/lib/rules/best-practises/no-unused-vars.js
@@ -31,7 +31,7 @@ class NoUnusedVarsChecker extends BaseChecker {
 
     if (!ignoreWhen(funcWithoutBlock, emptyBlock)) {
       VarUsageScope.activate(node)
-      node.parameters.forEach(parameter => {
+      node.parameters.filter(parameter => parameter.name).forEach(parameter => {
         this._addVariable(parameter)
       })
     }

diff --git a/test/rules/best-practises/no-unused-vars.js b/test/rules/best-practises/no-unused-vars.js
@@ -71,6 +71,20 @@ describe('Linter - no-unused-vars', () => {
     })
   )
 
+  it('should not emit an error in override functions without parameter names', () => {
+    const code = contractWith(`
+function withdrawalAllowed(address) public view override returns (bool) {
+    return _state == State.Refunding;
+}
+    `)
+
+    const report = linter.processStr(code, {
+      rules: { 'no-unused-vars': 'warn' }
+    })
+
+    assertNoWarnings(report)
+  })
+
   function label(data) {
     const items = data.split('\n')
     const lastItemIndex = items.length - 1