Remove mark-callable-contracts from recommended ruleset

celo-org · May 1, 2020 · fc7048b · fc7048b
1 parent 7d5aea8
commit fc7048b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/docs/rules.md b/docs/rules.md
@@ -2,7 +2,7 @@
 warning:     "This is a dynamically generated file. Do not edit manually."
 layout:      "default"
 title:       "Rule Index of Solhint"
-date:        "Thu, 23 Apr 2020 20:59:54 GMT"
+date:        "Fri, 01 May 2020 22:04:11 GMT"
 author:      "Franco Victorio <[email protected]>"
 ---
 
@@ -53,7 +53,7 @@ author:      "Franco Victorio <[email protected]>"
 | [check-send-result](./rules/security/check-send-result.md)             | Check result of "send" call.                                             | ✔️          |
 | [compiler-version](./rules/security/compiler-version.md)               | Compiler version must satisfy a semver requirement.                      | ✔️          |
 | [func-visibility](./rules/security/func-visibility.md)                 | Explicitly mark visibility in function.                                  | ✔️          |
-| [mark-callable-contracts](./rules/security/mark-callable-contracts.md) | Explicitly mark all external contracts as trusted or untrusted.          | ✔️          |
+| [mark-callable-contracts](./rules/security/mark-callable-contracts.md) | Explicitly mark all external contracts as trusted or untrusted.          |             |
 | [multiple-sends](./rules/security/multiple-sends.md)                   | Avoid multiple calls of "send" method in single transaction.             | ✔️          |
 | [no-complex-fallback](./rules/security/no-complex-fallback.md)         | Fallback function must be simple.                                        | ✔️          |
 | [no-inline-assembly](./rules/security/no-inline-assembly.md)           | Avoid to use inline assembly. It is acceptable only in rare cases.       | ✔️          |

diff --git a/docs/rules/security/mark-callable-contracts.md b/docs/rules/security/mark-callable-contracts.md
@@ -2,16 +2,13 @@
 warning:     "This is a dynamically generated file. Do not edit manually."
 layout:      "default"
 title:       "mark-callable-contracts | Solhint"
-date:        "Thu, 23 Apr 2020 20:59:52 GMT"
+date:        "Fri, 01 May 2020 22:04:10 GMT"
 author:      "Franco Victorio <[email protected]>"
 ---
 
 # mark-callable-contracts
-![Recommended Badge](https://img.shields.io/badge/-Recommended-brightgreen)
 ![Category Badge](https://img.shields.io/badge/-Security%20Rules-informational)
 ![Default Severity Badge warn](https://img.shields.io/badge/Default%20Severity-warn-yellow)
-> The {"extends": "solhint:recommended"} property in a configuration file enables this rule.
-
 
 ## Description
 Explicitly mark all external contracts as trusted or untrusted.

diff --git a/lib/rules/security/mark-callable-contracts.js b/lib/rules/security/mark-callable-contracts.js
@@ -28,7 +28,7 @@ const meta = {
   },
 
   isDefault: false,
-  recommended: true,
+  recommended: false,
   defaultSetup: 'warn',
 
   schema: null