Skip to content

Commit

Permalink
chore(sql_lab): Added Unit Test for stop query exception (apache#17464)
Browse files Browse the repository at this point in the history
* added unit test

* feedback implemented
  • Loading branch information
AAfghahi authored Nov 19, 2021
1 parent 8e1619b commit 69c3cc7
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions tests/integration_tests/core_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1547,6 +1547,28 @@ def test_dashboard_injected_exceptions(self, mock_db_connection_mutator):
data = self.get_resp(url)
self.assertIn("Error message", data)

@mock.patch("superset.sql_lab.cancel_query")
@mock.patch("superset.views.core.db.session")
def test_stop_query_not_implemented(
self, mock_superset_db_session, mock_sql_lab_cancel_query
):
"""
Handles stop query when the DB engine spec does not
have a cancel query method.
"""
form_data = {"client_id": "foo"}
query_mock = mock.Mock()
query_mock.client_id = "foo"
query_mock.status = QueryStatus.RUNNING
self.login(username="admin")
mock_superset_db_session.query().filter_by().one().return_value = query_mock
mock_sql_lab_cancel_query.return_value = False
rv = self.client.post(
"/superset/stop_query/", data={"form_data": json.dumps(form_data)},
)

assert rv.status_code == 422


if __name__ == "__main__":
unittest.main()

0 comments on commit 69c3cc7

Please sign in to comment.