fix: updateWysiwygStyle updatedElement is undefined TypeError (excali…

…draw#4980) Co-authored-by: dwelle <[email protected]>
cenkce · Mar 27, 2022 · e940aeb · e940aeb
1 parent 580e719
commit e940aeb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/element/textWysiwyg.tsx b/src/element/textWysiwyg.tsx
@@ -102,9 +102,11 @@ export const textWysiwyg = ({
 
   const updateWysiwygStyle = () => {
     const appState = app.state;
-    const updatedElement = Scene.getScene(element)?.getElement(
-      id,
-    ) as ExcalidrawTextElement;
+    const updatedElement =
+      Scene.getScene(element)?.getElement<ExcalidrawTextElement>(id);
+    if (!updatedElement) {
+      return;
+    }
     const { textAlign, verticalAlign } = updatedElement;
 
     const approxLineHeight = getApproxLineHeight(getFontString(updatedElement));

diff --git a/src/scene/Scene.ts b/src/scene/Scene.ts
@@ -62,8 +62,8 @@ class Scene {
     return this.nonDeletedElements;
   }
 
-  getElement(id: ExcalidrawElement["id"]): ExcalidrawElement | null {
-    return this.elementsMap.get(id) || null;
+  getElement<T extends ExcalidrawElement>(id: T["id"]): T | null {
+    return (this.elementsMap.get(id) as T | undefined) || null;
   }
 
   getNonDeletedElement(