Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

No limit on number of active spans kept in memory by zpages SpanStore #597

Open
semistrict opened this issue Mar 16, 2018 · 0 comments
Open

Comments

@semistrict
Copy link
Contributor

We should not keep an unbounded number of spans in the active set in spanStore. If a user starts a span without ending it, this will cause a memory leak.

Yes, this is working around potential bugs in user code. But we have actually seen this in the wild (in the Datastore custom spans) and the only reason this didn't cause crashes is that the zpages are not automatically imported. Anyone importing zpages would see a memory leak.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants