Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TokenReview RBAC to support CSI addons security enhancements #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TokenReview RBAC to support CSI addons security enhancements #197

wants to merge 1 commit into from

Conversation

bipuladh
Copy link

@bipuladh bipuladh commented Jan 15, 2025 •
edited
Loading

Describe what this PR does

Introduce changes to support CSI addons security changes introduced in csi-addons/kubernetes-csi-addons#692

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Madhu-1
Madhu-1 requested changes Jan 15, 2025
View reviewed changes
config/csi-rbac/rbd_ctrlplugin_role.yaml Outdated Show resolved Hide resolved
config/csi-rbac/cephfs_nodeplugin_cluster_role.yaml Outdated Show resolved Hide resolved
config/csi-rbac/cephfs_ctrlplugin_cluster_role.yaml Outdated Show resolved Hide resolved
config/csi-rbac/nfs_ctrlplugin_cluster_role.yaml Outdated Show resolved Hide resolved
config/csi-rbac/nfs_nodeplugin_cluster_role.yaml Outdated Show resolved Hide resolved
config/csi-rbac/rbd_ctrlplugin_cluster_role.yaml Outdated Show resolved Hide resolved
@bipuladh bipuladh requested a review from Madhu-1 January 15, 2025 11:01
Madhu-1
Madhu-1 reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @bipuladh are you able to test this change as we don't have CI job to validate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bipuladh @Madhu-1