-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-ceph: bump github.com/aws/smithy-go from 1.22.2 to 1.22.3 #1083
base: master
Are you sure you want to change the base?
go-ceph: bump github.com/aws/smithy-go from 1.22.2 to 1.22.3 #1083
Conversation
@@ -1,13 +1,14 @@ | |||
module github.com/ceph/go-ceph | |||
|
|||
go 1.21 | |||
toolchain go1.22.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this addition is due to the updated minimum Go version for the package which is greater than the version specified just above in the "go" line.
Module Highlights
- github.com/aws/smithy-go: v1.22.3
- Dependency Update: Bump minimum Go version to 1.22 per our language support policy.
@phlogistonjohn Does that mean we bump our Go version too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to (re)read https://go.dev/blog/toolchain to remind myself what this is. I think it'd be OK to bump up the go
line to 1.22
and set toolchain
to match. I do not think we need a 'z' value unless Go objects.
I think we should tackle this is a separate PR and then rebase this and other dependency PRs afterwards so that they only change the dependencies and not other properties of the go.mod file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that with #1085 go mod tidy
no longer adds the toolchain
line to go.mod while bumping github.com/aws/smithy-go
to v1.22.3.
@Mergifyio rebase |
Bumps [github.com/aws/smithy-go](https://github.com/aws/smithy-go) from 1.22.2 to 1.22.3. - [Release notes](https://github.com/aws/smithy-go/releases) - [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md) - [Commits](aws/smithy-go@v1.22.2...v1.22.3) --- updated-dependencies: - dependency-name: github.com/aws/smithy-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
✅ Branch has been successfully rebased |
eb6ef4a
to
b1fd473
Compare
Bumps github.com/aws/smithy-go from 1.22.2 to 1.22.3.
Release notes
Sourced from github.com/aws/smithy-go's releases.
Changelog
Sourced from github.com/aws/smithy-go's changelog.
... (truncated)
Commits
312566c
Release 2025-02-17590bb91
Bump go version to 1.22 (#569)0681fa9
Add metric and span support for CBOR serialize/deserialize (#566)d708d1d
coerce nil numbers to 0 in jmespath codegen (#565)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)