Remove illegal char check for project creation

cephaspad · May 17, 2021 · ed07b3c · ed07b3c
1 parent 05522af
commit ed07b3c
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 60 deletions.
diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Utils/ProjectNameValidator.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Utils/ProjectNameValidator.cs
@@ -17,40 +17,11 @@ public static class ProjectNameValidator
             "LPT2"
         };
 
-        private static readonly char[] IllegalChars = new[]
-        {
-            '/',
-            '?',
-            ':',
-            '&',
-            '\\',
-            '*',
-            '\'',
-            '<',
-            '>',
-            '|',
-            '#',
-            '%',
-        };
-
         private static bool HasParentDirectoryString(string projectName)
         {
             return projectName.Contains("..");
         }
 
-        private static bool HasIllegalChar(string projectName)
-        {
-            foreach (var illegalChar in IllegalChars)
-            {
-                if (projectName.Contains(illegalChar))
-                {
-                    return true;
-                }
-            }
-
-            return false;
-        }
-
         private static bool HasSurrogateOrControlChar(string projectName)
         {
             return projectName.Any(chr => char.IsControl(chr) || char.IsSurrogate(chr));
@@ -76,11 +47,6 @@ public static bool IsValid(string projectName)
                 throw new CliUsageException("Project name cannot be empty!");
             }
 
-            if (HasIllegalChar(projectName))
-            {
-                return false;
-            }
-
             if (HasSurrogateOrControlChar(projectName))
             {
                 return false;

diff --git a/framework/test/Volo.Abp.Cli.Core.Tests/Volo/Abp/Cli/ProjectNameValidation_Tests.cs b/framework/test/Volo.Abp.Cli.Core.Tests/Volo/Abp/Cli/ProjectNameValidation_Tests.cs
@@ -38,32 +38,6 @@ public async Task IllegalProjectName_Test()
             }
         }
 
-        [Fact]
-        public async Task ContainsIllegalChar_Test()
-        {
-            var illegalChars = new[]
-            {
-                '/',
-                '?',
-                ':',
-                '&',
-                '\\',
-                '*',
-                '\'',
-                '<',
-                '>',
-                '|',
-                '#',
-                '%',
-            };
-
-            foreach (var illegalChar in illegalChars)
-            {
-                var args = new CommandLineArgs("new", "Test" + illegalChar);
-                await _newCommand.ExecuteAsync(args).ShouldThrowAsync<CliUsageException>();
-            }
-        }
-
         [Fact]
         public async Task ParentDirectoryContain_Test()
         {