Skip to content

Commit

Permalink
Complete the renaming of qt_add_tool to qt_internal_add_tool
Browse files Browse the repository at this point in the history
Fix the name in the function's doc comment and error messages.

Change-Id: I918db802a0dbb0508f65d227f7c896d2ad0beeae
Reviewed-by: Alexey Edelev <[email protected]>
Reviewed-by: Craig Scott <[email protected]>
Reviewed-by: Cristian Adam <[email protected]>
(cherry picked from commit 728baba)
Reviewed-by: Fabian Kosmale <[email protected]>
  • Loading branch information
jobor committed Mar 7, 2021
1 parent 94f28c2 commit 5618d51
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cmake/QtToolHelpers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# We must pass this function a target name obtained from
# qt_get_tool_target_name like this:
# qt_get_tool_target_name(target_name my_tool)
# qt_add_tool(${target_name})
# qt_internal_add_tool(${target_name})
#
# Arguments:
# EXTRA_CMAKE_FILES
Expand All @@ -25,7 +25,7 @@ function(qt_internal_add_tool target_name)
qt_tool_target_to_name(name ${target_name})
set(one_value_keywords TOOLS_TARGET EXTRA_CMAKE_FILES INSTALL_DIR
${__default_target_info_args})
qt_parse_all_arguments(arg "qt_add_tool" "BOOTSTRAP;NO_QT;NO_INSTALL;USER_FACING"
qt_parse_all_arguments(arg "qt_internal_add_tool" "BOOTSTRAP;NO_QT;NO_INSTALL;USER_FACING"
"${one_value_keywords}"
"${__default_private_args}" ${ARGN})

Expand All @@ -39,7 +39,7 @@ function(qt_internal_add_tool target_name)

if(CMAKE_CROSSCOMPILING AND QT_BUILD_TOOLS_WHEN_CROSSCOMPILING AND (name STREQUAL target_name))
message(FATAL_ERROR
"qt_add_tool must be passed a target obtained from qt_get_tool_target_name.")
"qt_internal_add_tool must be passed a target obtained from qt_get_tool_target_name.")
endif()

set(full_name "${QT_CMAKE_EXPORT_NAMESPACE}::${name}")
Expand Down

0 comments on commit 5618d51

Please sign in to comment.