Skip to content

Commit

Permalink
CMake: Add TODO to apply generalized object library linking approach
Browse files Browse the repository at this point in the history
Pick-to: 6.2
Change-Id: I1ea368e81d8b055ef353a0f021f188b45588c937
Reviewed-by: Joerg Bornemann <[email protected]>
  • Loading branch information
alcroito committed Jun 17, 2021
1 parent 602d26c commit a37957d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cmake/QtPublicPluginHelpers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ function(__qt_internal_add_static_plugin_import_macro
__qt_internal_get_static_plugin_init_target_name("${plugin_target}" plugin_init_target)
set(objs_genex "$<TARGET_OBJECTS:${QT_CMAKE_EXPORT_NAMESPACE}::${plugin_init_target}>")

# TODO: Replace the target_sources call here with the more generalized approach that will be
# added to __qt_propagate_generated_resource (the one that determines whether to use
# target_sources or target_link_libraries depending on the CMake version).
target_sources(${QT_CMAKE_EXPORT_NAMESPACE}::${plugin_target} INTERFACE
"${objs_genex}")
endfunction()
Expand Down

0 comments on commit a37957d

Please sign in to comment.