nopSolutions#3998 RenderCheckbox values should not be limited to Id p…

…roperty
chan2will · Sep 5, 2019 · 0cd0579 · 0cd0579
1 parent fb5f157
commit 0cd0579
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Presentation/Nop.Web.Framework/Models/DataTables/RenderCheckBox.cs b/src/Presentation/Nop.Web.Framework/Models/DataTables/RenderCheckBox.cs
@@ -11,9 +11,11 @@ public partial class RenderCheckBox : IRender
         /// Initializes a new instance of the RenderCheckBox class 
         /// </summary>
         /// <param name="name">Checkbox name</param>
-        public RenderCheckBox(string name)
+        /// <param name="propertyKeyName">Property key name ("Id" by default). This property must be defined in the row dataset.</param>
+        public RenderCheckBox(string name, string propertyKeyName = "Id")
         {
             Name = name;
+            PropertyKeyName = propertyKeyName;
         }
 
         #endregion
@@ -25,6 +27,11 @@ public RenderCheckBox(string name)
         /// </summary>
         public string Name { get; set; }
 
+        /// <summary>
+        /// Gets or sets identificator for row 
+        /// </summary>
+        public string PropertyKeyName { get; set; }
+
         #endregion
     }
 }
diff --git a/src/Presentation/Nop.Web/Areas/Admin/Views/Shared/_Table.Definition.cshtml b/src/Presentation/Nop.Web/Areas/Admin/Views/Shared/_Table.Definition.cshtml
@@ -335,8 +335,8 @@ columns: [
                     <text>
                     render: function (data, type, row, meta) {
                         return (data === 'true')
-                            ? '<input name="@checkBox.Name" value="' + row.Id + '" type="checkbox" class="checkboxGroups" checked="checked" />'
-                            : '<input name="@checkBox.Name" value="' + row.Id + '" type="checkbox" class="checkboxGroups" />';
+                            ? '<input name="@checkBox.Name" value="' + row.@checkBox.PropertyKeyName + '" type="checkbox" class="checkboxGroups" checked="checked" />'
+                            : '<input name="@checkBox.Name" value="' + row.@checkBox.PropertyKeyName + '" type="checkbox" class="checkboxGroups" />';
                     },
                     </text>
                     break;