Minor: more helpful warning when an observable is leaked.

changjiashuai · Apr 11, 2017 · cf4363d · cf4363d
1 parent 0c0c552
commit cf4363d
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/client/rpc/src/main/kotlin/net/corda/client/rpc/CordaRPCClientImpl.kt b/client/rpc/src/main/kotlin/net/corda/client/rpc/CordaRPCClientImpl.kt
@@ -389,9 +389,13 @@ class CordaRPCClientImpl(private val session: ClientSession,
                     false
             }
             if (closed) {
-                rpcLog.warn("A hot observable returned from an RPC ($rpcName) was never subscribed to. " +
-                        "This wastes server-side resources because it was queueing observations for retrieval. " +
-                        "It is being closed now, but please adjust your code to subscribe and unsubscribe from the observable to close it explicitly.", rpcLocation)
+                rpcLog.warn("""A hot observable returned from an RPC ($rpcName) was never subscribed to.
+                               This wastes server-side resources because it was queueing observations for retrieval.
+                               It is being closed now, but please adjust your code to call .notUsed() on the observable
+                               to close it explicitly. (Java users: subscribe to it then unsubscribe). This warning
+                               will appear less frequently in future versions of the platform and you can ignore it
+                               if you want to.
+                            """.trimIndent().replace('\n', ' '), rpcLocation)
             }
         }
     }