Remove most t.Log() from tests (gravitational#28453)

The t.Log() function calls have been removed from most tests. This is to keep our test logs cleaner and more focused on error messages. Logging every detail in tests makes it harder to spot actual errors and relevant information.

integrations/kube-agent-updater/pkg/img/cosign_test.go

@@ -51,7 +51,6 @@ func Test_cosignKeyValidator_ValidateAndResolveDigest(t *testing.T) {
 	// This is the worst case scenario and also reduces the amount of noise and failed calls in the logs.
 	testRegistry := httptest.NewServer(registry.New(registry.WithReferrersSupport(true)))
 	t.Cleanup(testRegistry.Close)
-	t.Log(testRegistry.URL)
 
 	// Put test layers and manifests into the registry
 	for digest, contents := range blobs {

integrations/lib/testing/integration/ssh_test.go

@@ -77,8 +77,6 @@ func (s *IntegrationSSHSuite) TestSSH() {
 	require.NoError(t, err)
 
 	err = cmd.Wait()
-	t.Log("STDOUT", cmdStdout.String())
-	t.Log("STDERR", cmdStderr.String())
 	require.NoError(t, err)
 
 	require.Contains(t, cmdStdout.String(), fmt.Sprintf("MYUSER=%s", user.GetName()))

lib/cloud/aws/tags_helpers_test.go

@@ -44,7 +44,6 @@ func TestTagsToLabels(t *testing.T) {
 				Value: aws.String("test"),
 			},
 		}
-		t.Log(inputTags)
 
 		expectLabels := map[string]string{
 			"Name":                        "test",
@@ -71,7 +70,6 @@ func TestTagsToLabels(t *testing.T) {
 				Value: aws.String("test"),
 			},
 		}
-		t.Log(inputTags)
 
 		expectLabels := map[string]string{
 			"Name":                        "test",

lib/kube/proxy/auth_test.go

@@ -65,7 +65,6 @@ func TestCheckImpersonationPermissions(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		t.Log(tt.desc)
 		mock := &mockSARClient{
 			err:              tt.sarErr,
 			allowedVerbs:     tt.allowedVerbs,

lib/kube/proxy/forwarder_test.go

@@ -935,8 +935,6 @@ func TestSetupImpersonationHeaders(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		t.Log(tt.desc)
-
 		err := setupImpersonationHeaders(
 			logrus.NewEntry(logrus.New()),
 			authContext{
@@ -946,7 +944,6 @@ func TestSetupImpersonationHeaders(t *testing.T) {
 			},
 			tt.inHeaders,
 		)
-		t.Log("got error:", err)
 		tt.errAssertion(t, err)
 
 		if err == nil {

lib/srv/db/elasticsearch/util_test.go

@@ -132,7 +132,6 @@ func TestEngineGetQueryFromRequestBody(t *testing.T) {
 			e.Log = logrus.StandardLogger()
 
 			result := GetQueryFromRequestBody(e.EngineConfig, tt.contentType, []byte(tt.body))
-			t.Log(result)
 			require.Equal(t, tt.want, result)
 		})
 	}

lib/utils/archive_test.go

@@ -114,7 +114,6 @@ func TestCompressAsTarGzArchive(t *testing.T) {
 
 			gotBytes, err := io.ReadAll(tarReader)
 			require.NoError(t, err)
-			t.Log(string(gotBytes))
 
 			require.Equal(t, tt.fsContents[header.Name].content, gotBytes)
 			require.Equal(t, tt.fsContents[header.Name].mode, fs.FileMode(header.Mode))

lib/web/join_tokens_test.go

@@ -759,7 +759,6 @@ db_service:
 			}
 
 			if test.extraAssertions != nil {
-				t.Log(script)
 				test.extraAssertions(script)
 			}
 		})