Skip to content

Commit

Permalink
Rename avoid_duplicate_import to avoid_duplicate_imports
Browse files Browse the repository at this point in the history
  • Loading branch information
charlescyt committed Mar 5, 2024
1 parent fbc0a08 commit 99bd3b7
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 18 deletions.
2 changes: 1 addition & 1 deletion docs.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
["Dart Lints", [
["always_declare_parameter_names", "/dart-lints/always_declare_parameter_names"],
["avoid_abbreviations_in_doc_comments", "/dart-lints/avoid_abbreviations_in_doc_comments"],
["avoid_duplicate_import", "/dart-lints/avoid_duplicate_import"],
["avoid_duplicate_imports", "/dart-lints/avoid_duplicate_imports"],
["avoid_dynamic", "/dart-lints/avoid_dynamic"],
["avoid_empty_blocks", "/dart-lints/avoid_empty_blocks"],
["avoid_inverted_boolean_expressions", "/dart-lints/avoid_inverted_boolean_expressions"],
Expand Down
4 changes: 2 additions & 2 deletions docs/available-lints.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
| -------------------------------------------------- |:--------:|:---------:|:-------:|
| [always_declare_parameter_names] | Info |||
| [avoid_abbreviations_in_doc_comments] | Warning |||
| [avoid_duplicate_import] | Info |||
| [avoid_duplicate_imports] | Info |||
| [avoid_dynamic] | Info |||
| [avoid_empty_blocks] | Warning |||
| [avoid_inverted_boolean_expressions] | Info |||
Expand Down Expand Up @@ -60,7 +60,7 @@

[always_declare_parameter_names]: https://docs.page/charlescyt/pyramid_lint/dart-lints/always_declare_parameter_names
[avoid_abbreviations_in_doc_comments]: https://docs.page/charlescyt/pyramid_lint/dart-lints/avoid_abbreviations_in_doc_comments
[avoid_duplicate_import]: https://docs.page/charlescyt/pyramid_lint/dart-lints/avoid_duplicate_import
[avoid_duplicate_imports]: https://docs.page/charlescyt/pyramid_lint/dart-lints/avoid_duplicate_imports
[avoid_dynamic]: https://docs.page/charlescyt/pyramid_lint/dart-lints/avoid_dynamic
[avoid_empty_blocks]: https://docs.page/charlescyt/pyramid_lint/dart-lints/avoid_empty_blocks
[avoid_inverted_boolean_expressions]: https://docs.page/charlescyt/pyramid_lint/dart-lints/avoid_inverted_boolean_expressions
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# avoid_duplicate_import
# avoid_duplicate_imports

| Severity | Quick Fix | Options |
|:--------:|:---------:|:-------:|
Expand All @@ -25,10 +25,10 @@ final b = math.min(1, 10);

## Usage

To enable the `avoid_duplicate_import` rule, add `avoid_duplicate_import` under custom_lint > rules in your `analysis_options.yaml` file:
To enable the `avoid_duplicate_imports` rule, add `avoid_duplicate_imports` under custom_lint > rules in your `analysis_options.yaml` file:

```yaml
custom_lint:
rules:
- avoid_duplicate_import
- avoid_duplicate_imports
```
2 changes: 1 addition & 1 deletion docs/getting-started.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ custom_lint:
# Dart lints
- always_declare_parameter_names
- avoid_abbreviations_in_doc_comments
- avoid_duplicate_import
- avoid_duplicate_imports
- avoid_dynamic
- avoid_empty_blocks
- avoid_mutable_global_variables
Expand Down
1 change: 1 addition & 0 deletions packages/pyramid_lint/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### Changed

- **BREAKING**: All lints are now disabled by default. You need to enable them in your `analysis_options.yaml` file.
- **BREAKING**: `avoid_duplicate_import` is renamed to `avoid_duplicate_imports`.
- Pump the minimum `custom_lint_builder` version to 0.6.2.
- Fix false positive for `avoid_nested_if` when the if statement is a else if statement.

Expand Down
2 changes: 1 addition & 1 deletion packages/pyramid_lint/example/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ custom_lint:
# Dart lints
- always_declare_parameter_names
- avoid_abbreviations_in_doc_comments
- avoid_duplicate_import
- avoid_duplicate_imports
- avoid_dynamic
- avoid_empty_blocks
- avoid_mutable_global_variables
Expand Down
4 changes: 2 additions & 2 deletions packages/pyramid_lint/lib/pyramid_lint.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import 'src/assists/flutter/wrap_with_stack.dart';
import 'src/assists/flutter/wrap_with_value_listenable_builder.dart';
import 'src/lints/dart/always_declare_parameter_names.dart';
import 'src/lints/dart/avoid_abbreviations_in_doc_comments.dart';
import 'src/lints/dart/avoid_duplicate_import.dart';
import 'src/lints/dart/avoid_duplicate_imports.dart';
import 'src/lints/dart/avoid_dynamic.dart';
import 'src/lints/dart/avoid_empty_blocks.dart';
import 'src/lints/dart/avoid_inverted_boolean_expressions.dart';
Expand Down Expand Up @@ -65,7 +65,7 @@ class _PyramidLinter extends PluginBase {
// Dart lints
AlwaysDeclareParameterNames.fromConfigs(configs),
AvoidAbbreviationsInDocComments.fromConfigs(configs),
AvoidDuplicateImport.fromConfigs(configs),
AvoidDuplicateImports.fromConfigs(configs),
AvoidDynamic.fromConfigs(configs),
AvoidEmptyBlocks.fromConfigs(configs),
AvoidInvertedBooleanExpressions.fromConfigs(configs),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import '../../pyramid_lint_rule.dart';
import '../../utils/constants.dart';
import '../../utils/iterable_extension.dart';

class AvoidDuplicateImport extends PyramidLintRule {
AvoidDuplicateImport({required super.options})
class AvoidDuplicateImports extends PyramidLintRule {
AvoidDuplicateImports({required super.options})
: super(
name: ruleName,
problemMessage: 'Duplicate imports can lead to confusion.',
Expand All @@ -18,17 +18,17 @@ class AvoidDuplicateImport extends PyramidLintRule {
errorSeverity: ErrorSeverity.INFO,
);

static const ruleName = 'avoid_duplicate_import';
static const ruleName = 'avoid_duplicate_imports';
static const url = '$dartLintDocUrl/$ruleName';

factory AvoidDuplicateImport.fromConfigs(CustomLintConfigs configs) {
factory AvoidDuplicateImports.fromConfigs(CustomLintConfigs configs) {
final json = configs.rules[ruleName]?.json ?? {};
final options = PyramidLintRuleOptions.fromJson(
json: json,
paramsConverter: (_) => null,
);

return AvoidDuplicateImport(options: options);
return AvoidDuplicateImports(options: options);
}

@override
Expand Down
2 changes: 1 addition & 1 deletion packages/pyramid_lint_test/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ custom_lint:
- always_declare_parameter_names
- avoid_abbreviations_in_doc_comments:
abbreviations: ["approx."]
- avoid_duplicate_import
- avoid_duplicate_imports
- avoid_dynamic
- avoid_empty_blocks
- avoid_mutable_global_variables
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// ignore_for_file: unused_local_variable, prefer_library_prefixes

// expect_lint: avoid_duplicate_import
// expect_lint: avoid_duplicate_imports
import 'dart:math' as math show max;
// expect_lint: avoid_duplicate_import
// expect_lint: avoid_duplicate_imports
import 'dart:math';

void example() {
Expand Down

0 comments on commit 99bd3b7

Please sign in to comment.