-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage testing and tests. #109
Open
knz
wants to merge
23
commits into
charmbracelet:master
Choose a base branch
from
knz:20220903-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,610
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit: done |
knz
force-pushed
the
20220903-changes
branch
4 times, most recently
from
September 3, 2022 16:47
c1a4c6a
to
03db858
Compare
knz
force-pushed
the
20220903-changes
branch
from
September 3, 2022 17:17
85de1f4
to
b51757b
Compare
knz
force-pushed
the
20220903-changes
branch
from
September 3, 2022 18:18
d13f482
to
f65eb7f
Compare
knz
force-pushed
the
20220903-changes
branch
from
September 3, 2022 19:05
c6de6b3
to
4bac2d4
Compare
This was referenced Sep 3, 2022
knz
force-pushed
the
20220903-changes
branch
from
September 3, 2022 21:31
eb08616
to
bfcaf17
Compare
This was referenced Sep 3, 2022
Open
knz
force-pushed
the
20220903-changes
branch
from
September 3, 2022 22:26
f380c8a
to
89838b3
Compare
knz
force-pushed
the
20220903-changes
branch
from
September 7, 2022 22:11
89838b3
to
ff8fdd6
Compare
I've updated the PR to lipgloss 0.6. |
This is now rebased and again ready to go. |
bashbunni
requested review from
meowgorithm and
aymanbagabas
as code owners
September 13, 2024 19:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111.
Example test file: https://github.com/knz/lipgloss/blob/20220903-changes/testdata/borders
Other issues found thanks to this PR:
UnderlineSpaces
andStrikethroughSpaces
don't seem to work properly #113Coverage results: https://coveralls.io/github/knz/lipgloss