Remove outdated unused element suppressions (flutter#28775)

Fixes flutter/flutter#35164
chaselatta · Sep 23, 2021 · 7d023e8 · 7d023e8
1 parent eb94e4f
commit 7d023e8
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 22 deletions.
diff --git a/lib/ui/annotations.dart b/lib/ui/annotations.dart
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(dnfield): Remove unused_import ignores when https://github.com/dart-lang/sdk/issues/35164 is resolved.
-
 
 // @dart = 2.12
 part of dart.ui;

diff --git a/lib/ui/hooks.dart b/lib/ui/hooks.dart
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(dnfield): Remove unused_import ignores when https://github.com/dart-lang/sdk/issues/35164 is resolved.
-
 
 // @dart = 2.12
 part of dart.ui;
@@ -53,78 +51,65 @@ void _updateWindowMetrics(
 typedef _LocaleClosure = String Function();
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 _LocaleClosure? _getLocaleClosure() => PlatformDispatcher.instance._localeClosure;
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _updateLocales(List<String> locales) {
   PlatformDispatcher.instance._updateLocales(locales);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _updateUserSettingsData(String jsonData) {
   PlatformDispatcher.instance._updateUserSettingsData(jsonData);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _updateLifecycleState(String state) {
   PlatformDispatcher.instance._updateLifecycleState(state);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _updateSemanticsEnabled(bool enabled) {
   PlatformDispatcher.instance._updateSemanticsEnabled(enabled);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _updateAccessibilityFeatures(int values) {
   PlatformDispatcher.instance._updateAccessibilityFeatures(values);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _dispatchPlatformMessage(String name, ByteData? data, int responseId) {
   PlatformDispatcher.instance._dispatchPlatformMessage(name, data, responseId);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _dispatchPointerDataPacket(ByteData packet) {
   PlatformDispatcher.instance._dispatchPointerDataPacket(packet);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _dispatchKeyData(ByteData packet, int responseId) {
   PlatformDispatcher.instance._dispatchKeyData(packet, responseId);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _dispatchSemanticsAction(int id, int action, ByteData? args) {
   PlatformDispatcher.instance._dispatchSemanticsAction(id, action, args);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _beginFrame(int microseconds, int frameNumber) {
   PlatformDispatcher.instance._beginFrame(microseconds);
   PlatformDispatcher.instance._updateFrameData(frameNumber);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _reportTimings(List<int> timings) {
   PlatformDispatcher.instance._reportTimings(timings);
 }
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _drawFrame() {
   PlatformDispatcher.instance._drawFrame();
 }
@@ -133,7 +118,6 @@ void _drawFrame() {
 typedef _ListStringArgFunction(List<String> args);
 
 @pragma('vm:entry-point')
-// ignore: unused_element
 void _runMainZoned(Function startMainIsolateFunction,
                    Function userMainFunction,
                    List<String> args) {
@@ -246,7 +230,6 @@ bool _isLoopback(String host) {
 /// Zone override with 'flutter.io.allow_http' takes first priority.
 /// If zone override is not provided, engine setting is checked.
 @pragma('vm:entry-point')
-// ignore: unused_element
 void Function(Uri) _getHttpConnectionHookClosure(bool mayInsecurelyConnectToAllDomains) {
   return (Uri uri) {
       final dynamic zoneOverride = Zone.current[#flutter.io.allow_http];

diff --git a/lib/ui/natives.dart b/lib/ui/natives.dart
@@ -82,6 +82,6 @@ Function? _getCallbackFromHandle(int handle) native 'GetCallbackFromHandle';
 int? _isolateId; // ignore: unused_element
 
 @pragma('vm:entry-point')
-Function _getPrintClosure() => _print;  // ignore: unused_element
+Function _getPrintClosure() => _print;
 @pragma('vm:entry-point')
-Function _getScheduleMicrotaskClosure() => _scheduleMicrotask; // ignore: unused_element
+Function _getScheduleMicrotaskClosure() => _scheduleMicrotask;
diff --git a/runtime/fixtures/runtime_test.dart b/runtime/fixtures/runtime_test.dart
@@ -126,7 +126,7 @@ class _PluginRegistrant {
 
 
 @pragma('vm:entry-point')
-void mainForPluginRegistrantTest() { // ignore: unused_element
+void mainForPluginRegistrantTest() {
   if (didCallRegistrantBeforeEntrypoint) {
     passMessage('_PluginRegistrant.register() was called');
   } else {