SAK-30828 slf4j-log4j12 binding should be provided

chc24 · Apr 27, 2016 · f4e8903 · f4e8903
1 parent dfa2947
commit f4e8903
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/kernel/deploy/common/pom.xml b/kernel/deploy/common/pom.xml
@@ -40,7 +40,6 @@
       <artifactId>jcl-over-slf4j</artifactId>
       <scope>compile</scope>
     </dependency>
-    <!-- needed by Ehcache -->
     <dependency>
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-log4j12</artifactId>

diff --git a/master/pom.xml b/master/pom.xml
@@ -582,7 +582,7 @@
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-log4j12</artifactId>
         <version>${sakai.slf4j.version}</version>
-        <scope>runtime</scope>
+        <scope>provided</scope>
       </dependency>
       <!-- log4j is the actual logger used by slf4j, this would be removed if using a different logging impl -->
       <!-- change to scope runtime once all sakai log4j code is switched to slf4j -->

diff --git a/site-manage/site-manage-impl/impl/pom.xml b/site-manage/site-manage-impl/impl/pom.xml
@@ -98,6 +98,12 @@
             <groupId>com.github.javafaker</groupId>
             <artifactId>javafaker</artifactId>
             <version>0.4</version>
+	    <exclusions>
+		    <exclusion>
+			    <groupId>org.slf4j</groupId>
+			    <artifactId>slf4j-simple</artifactId>
+		    </exclusion>
+	    </exclusions>
         </dependency>
         <dependency>
         	<groupId>org.sakaiproject.entitybroker</groupId>