Refactor Spree::Order - using -> notation for lambda

chen-rubyer · Apr 2, 2013 · 556cf76 · 556cf76
1 parent 6465730
commit 556cf76
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rb
@@ -15,15 +15,17 @@ class Order < ActiveRecord::Base
     checkout_flow do
       go_to_state :address
       go_to_state :delivery
-      go_to_state :payment, if: lambda { |order|
+      go_to_state :payment, if: ->(order) do
         # Fix for #2191
         if order.shipments
           order.update_totals
         end
         order.payment_required?
+      end
+      go_to_state :confirm, if: ->(order) { order.confirmation_required? }
+      go_to_state :complete, if: ->(order) {
+        (order.payment_required? && order.has_unprocessed_payments?) || !order.payment_required?
       }
-      go_to_state :confirm, if: lambda { |order| order.confirmation_required? }
-      go_to_state :complete, if: lambda { |order| (order.payment_required? && order.has_unprocessed_payments?) || !order.payment_required? }
       remove_transition from: :delivery, to: :confirm
     end