x86: fix a mem leaking issue in X86_insn_combine()

chengshuyi · Jan 25, 2014 · 9389947 · 9389947
1 parent 3aebd8c
commit 9389947
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/arch/X86/X86Mapping.c b/arch/X86/X86Mapping.c
@@ -6686,5 +6686,8 @@ void X86_insn_combine(cs_struct *h, cs_insn *insn, cs_insn *prev)
 		uint8_t prefix = prev->detail->x86.opcode[0];
 		memmove(prev->detail, insn->detail, sizeof(cs_detail));
 		prev->detail->x86.prefix[0] = prefix;
+		// then free unused memory
+		cs_mem_free(insn->detail);
+		insn->detail = NULL;
 	}
 }
diff --git a/suite/benchmark.py b/suite/benchmark.py
@@ -73,6 +73,7 @@ def cs(md, code):
 
     try:
         md = Cs(arch, mode)
+        #md.detail = True
 
         if syntax != 0:
             md.syntax = syntax