ovsdb-idl: Avoid sending redundant conditional monitoring updates

In case connection is reset when there are buffered but unsent conditions, these conditions will be sent as the new "monitor_cond" message that will be sent after the idl reconnects. Without this patch, those conditions will be unnecessarily sent again with following monitoring condition update message. Signed-off-by: Andy Zhou <[email protected]> Acked-by: Ben Pfaff <[email protected]>
chengweiv5 · Jan 6, 2017 · 5351980 · 5351980
1 parent 790e2d4
commit 5351980
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
@@ -345,6 +345,7 @@ ovsdb_idl_clear(struct ovsdb_idl *idl)
         struct ovsdb_idl_table *table = &idl->tables[i];
         struct ovsdb_idl_row *row, *next_row;
 
+        table->cond_changed = false;
         if (hmap_is_empty(&table->rows)) {
             continue;
         }
@@ -370,6 +371,7 @@ ovsdb_idl_clear(struct ovsdb_idl *idl)
         }
     }
 
+    idl->cond_changed = false;
     ovsdb_idl_track_clear(idl);
 
     if (changed) {