SAK-50421 LTI improve handling for non-XML POSTs setting/deleting gra…

…des (sakaiproject#12821)
chenxingqiang · Aug 26, 2024 · ea800ec · ea800ec
1 parent 75b7fbd
commit ea800ec
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/basiclti/basiclti-blis/src/java/org/sakaiproject/blti/ServiceServlet.java b/basiclti/basiclti-blis/src/java/org/sakaiproject/blti/ServiceServlet.java
@@ -518,9 +518,17 @@ protected void processOutcome(HttpServletRequest request, HttpServletResponse re
 				}
 		    } else if ( isDelete ) {
 				retval = SakaiBLTIUtil.deleteGrade(sourcedid, request, ltiService);
+				if (retval instanceof String) {
+					doError(request, response, theMap, "outcome.fail", (String) retval, null);
+					return;
+				}
 			} else {
 				dGrade = new Double(result_resultscore_textstring);
 				retval = SakaiBLTIUtil.setGrade(sourcedid, request, ltiService, dGrade, result_resultdata_text);
+				if (retval instanceof String) {
+					doError(request, response, theMap, "outcome.fail", (String) retval, null);
+					return;
+				}
 			}
 			success = true;
 			theMap.put("/message_response/statusinfo/codemajor", "Success");