Added proper validation for speechDurationMs and speechDurationMs

chenying99 · Dec 23, 2023 · f6d9459 · f6d9459
1 parent 71ac722
commit f6d9459
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/silero/src/main/java/com/konovalov/vad/silero/VadSilero.kt b/silero/src/main/java/com/konovalov/vad/silero/VadSilero.kt
@@ -380,8 +380,8 @@ class VadSilero(
      */
     var speechDurationMs: Int = speechDurationMs
         set(speechDurationMs) {
-            require(speechDurationMs >= 0) {
-                "The parameter 'speechDurationMs' cannot be smaller than zero!"
+            require(speechDurationMs in 0..300000) {
+                "The parameter 'speechDurationMs' should be >= 0ms and <= 300000ms!"
             }
 
             field = speechDurationMs
@@ -399,8 +399,8 @@ class VadSilero(
      */
     var silenceDurationMs: Int = silenceDurationMs
         set(silenceDurationMs) {
-            require(silenceDurationMs >= 0) {
-                "The parameter 'silenceDurationMs' cannot be smaller than zero!"
+            require(silenceDurationMs in 0..300000) {
+                "The parameter 'silenceDurationMs' should be >= 0ms and <= 300000ms!"
             }
 
             field = silenceDurationMs

diff --git a/webrtc/src/main/java/com/konovalov/vad/webrtc/VadWebRTC.kt b/webrtc/src/main/java/com/konovalov/vad/webrtc/VadWebRTC.kt
@@ -295,8 +295,8 @@ class VadWebRTC(
      */
     var speechDurationMs: Int = speechDurationMs
         set(speechDurationMs) {
-            require(speechDurationMs >= 0) {
-                "The parameter 'speechDurationMs' cannot be smaller than zero!"
+            require(speechDurationMs in 0..300000) {
+                "The parameter 'speechDurationMs' should be >= 0ms and <= 300000ms!"
             }
 
             field = speechDurationMs
@@ -314,8 +314,8 @@ class VadWebRTC(
      */
     var silenceDurationMs: Int = silenceDurationMs
         set(silenceDurationMs) {
-            require(silenceDurationMs >= 0) {
-                "The parameter 'silenceDurationMs' cannot be smaller than zero!"
+            require(silenceDurationMs in 0..300000) {
+                "The parameter 'silenceDurationMs' should be >= 0ms and <= 300000ms!"
             }
 
             field = silenceDurationMs

diff --git a/yamnet/src/main/java/com/konovalov/vad/yamnet/VadYamnet.kt b/yamnet/src/main/java/com/konovalov/vad/yamnet/VadYamnet.kt
@@ -374,8 +374,8 @@ class VadYamnet(
      */
     var speechDurationMs: Int = speechDurationMs
         set(speechDurationMs) {
-            require(speechDurationMs >= 0) {
-                "The parameter 'speechDurationMs' cannot be smaller than zero!"
+            require(speechDurationMs in 0..300000) {
+                "The parameter 'speechDurationMs' should be >= 0ms and <= 300000ms!"
             }
 
             field = speechDurationMs
@@ -393,8 +393,8 @@ class VadYamnet(
      */
     var silenceDurationMs: Int = silenceDurationMs
         set(silenceDurationMs) {
-            require(silenceDurationMs >= 0) {
-                "The parameter 'silenceDurationMs' cannot be smaller than zero!"
+            require(silenceDurationMs in 0..300000) {
+                "The parameter 'silenceDurationMs' should be >= 0ms and <= 300000ms!"
             }
 
             field = silenceDurationMs