forked from JumpingYang001/webrtc
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated PeerConnection integration test to fix race condition.
The PeerConnection integration test was creating TurnServers on the stack on the signaling thread. This could cause a race condition problem when the test was being taken down. Since the turn server was destructed on the signaling thread, a socket might still try and send to it after it was destroyed causing a seg fault. This change creates/destroys the TestTurnServers on the network thread to fix this issue. Bug: None Change-Id: I080098502b737f0972ce2fa5357920de057a3312 Reviewed-on: https://webrtc-review.googlesource.com/81301 Reviewed-by: Qingsi Wang <[email protected]> Reviewed-by: Steve Anton <[email protected]> Commit-Queue: Seth Hampson <[email protected]> Cr-Commit-Position: refs/heads/master@{#23590}
- Loading branch information
Seth Hampson
authored and
Commit Bot
committed
Jun 13, 2018
1 parent
2cf61e3
commit aed7164
Showing
5 changed files
with
167 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.