Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fiirl serializer] Fix for #4791 #4795

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tobias1012
Copy link
Contributor

@tobias1012 tobias1012 commented Mar 14, 2025

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Fixed improper path escape on windows platform during firrtl serialization. Note the makefile in svsim is still not windows compatible.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@tobias1012
Copy link
Contributor Author

Looks like old commit already merged got in this pull request too, not sure how to fix.

@seldridge seldridge added the Bugfix Fixes a bug, will be included in release notes label Mar 14, 2025
@tobias1012
Copy link
Contributor Author

tobias1012 commented Mar 15, 2025

This PR seems to fix the last issue apart from the makefile, however I am having a bit of trouble compiling on windows with the oss-cad-suite as the verilator runtime seems to have trouble finding paths generated by chisel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants