Explain mutability of bastion configuration in CRD

chrischdi · Mar 31, 2022 · 47fbf53 · 47fbf53
1 parent 5d7d0a3
commit 47fbf53
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 7 deletions.
diff --git a/api/v1alpha3/openstackcluster_types.go b/api/v1alpha3/openstackcluster_types.go
@@ -107,6 +107,10 @@ type OpenStackClusterSpec struct {
 	ControlPlaneAvailabilityZones []string `json:"controlPlaneAvailabilityZones,omitempty"`
 
 	// Bastion is the OpenStack instance to login the nodes
+	//
+	// As a rolling update is not ideal during a bastion host session, we
+	// prevent changes to a running bastion configuration. Set `enabled: false` to
+	// make changes.
 	//+optional
 	Bastion *Bastion `json:"bastion,omitempty"`
 }

diff --git a/api/v1alpha4/openstackcluster_types.go b/api/v1alpha4/openstackcluster_types.go
@@ -130,6 +130,10 @@ type OpenStackClusterSpec struct {
 	ControlPlaneAvailabilityZones []string `json:"controlPlaneAvailabilityZones,omitempty"`
 
 	// Bastion is the OpenStack instance to login the nodes
+	//
+	// As a rolling update is not ideal during a bastion host session, we
+	// prevent changes to a running bastion configuration. Set `enabled: false` to
+	// make changes.
 	//+optional
 	Bastion *Bastion `json:"bastion,omitempty"`
 

diff --git a/api/v1beta1/openstackcluster_types.go b/api/v1beta1/openstackcluster_types.go
@@ -130,6 +130,10 @@ type OpenStackClusterSpec struct {
 	ControlPlaneAvailabilityZones []string `json:"controlPlaneAvailabilityZones,omitempty"`
 
 	// Bastion is the OpenStack instance to login the nodes
+	//
+	// As a rolling update is not ideal during a bastion host session, we
+	// prevent changes to a running bastion configuration. Set `enabled: false` to
+	// make changes.
 	//+optional
 	Bastion *Bastion `json:"bastion,omitempty"`
 

diff --git a/config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml b/config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml
@@ -82,7 +82,10 @@ spec:
                   APIServer will be created
                 type: integer
               bastion:
-                description: Bastion is the OpenStack instance to login the nodes
+                description: "Bastion is the OpenStack instance to login the nodes
+                  \n As a rolling update is not ideal during a bastion host session,
+                  we prevent changes to a running bastion configuration. Set `enabled:
+                  false` to make changes."
                 properties:
                   availabilityZone:
                     type: string
@@ -1106,7 +1109,10 @@ spec:
                   APIServer will be created
                 type: integer
               bastion:
-                description: Bastion is the OpenStack instance to login the nodes
+                description: "Bastion is the OpenStack instance to login the nodes
+                  \n As a rolling update is not ideal during a bastion host session,
+                  we prevent changes to a running bastion configuration. Set `enabled:
+                  false` to make changes."
                 properties:
                   availabilityZone:
                     type: string
@@ -2510,7 +2516,10 @@ spec:
                   APIServer will be created
                 type: integer
               bastion:
-                description: Bastion is the OpenStack instance to login the nodes
+                description: "Bastion is the OpenStack instance to login the nodes
+                  \n As a rolling update is not ideal during a bastion host session,
+                  we prevent changes to a running bastion configuration. Set `enabled:
+                  false` to make changes."
                 properties:
                   availabilityZone:
                     type: string

diff --git a/config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yaml b/config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yaml
@@ -87,8 +87,10 @@ spec:
                           on the APIServer will be created
                         type: integer
                       bastion:
-                        description: Bastion is the OpenStack instance to login the
-                          nodes
+                        description: "Bastion is the OpenStack instance to login the
+                          nodes \n As a rolling update is not ideal during a bastion
+                          host session, we prevent changes to a running bastion configuration.
+                          Set `enabled: false` to make changes."
                         properties:
                           availabilityZone:
                             type: string
@@ -775,8 +777,10 @@ spec:
                           on the APIServer will be created
                         type: integer
                       bastion:
-                        description: Bastion is the OpenStack instance to login the
-                          nodes
+                        description: "Bastion is the OpenStack instance to login the
+                          nodes \n As a rolling update is not ideal during a bastion
+                          host session, we prevent changes to a running bastion configuration.
+                          Set `enabled: false` to make changes."
                         properties:
                           availabilityZone:
                             type: string