Skip to content

Commit

Permalink
tools/power turbostat: fix IVB support
Browse files Browse the repository at this point in the history
Initial IVB support went into turbostat in Linux-3.1:
553575f
(tools turbostat: recognize and run properly on IVB)

However, when running on IVB, turbostat would fail
to report the new couters added with SNB, c7, pc2 and pc7.
So in scenarios where these counters are non-zero on IVB,
turbostat would report erroneous residencey results.

In particular c7 time would be added to c1 time,
since c1 time is calculated as "that which is left over".

Also, turbostat reports MHz capabilities when passed
the "-v" option, and it would incorrectly report 133MHz
bclk instead of 100MHz bclk for IVB, which would inflate
GHz reported with that option.

This patch is a backport of a fix already included in turbostat v2.

Signed-off-by: Len Brown <[email protected]>
  • Loading branch information
lenb committed Jun 4, 2012
1 parent d15cf7c commit 650a37f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/power/x86/turbostat/turbostat.c
Original file line number Diff line number Diff line change
Expand Up @@ -933,6 +933,8 @@ int is_snb(unsigned int family, unsigned int model)
switch (model) {
case 0x2A:
case 0x2D:
case 0x3A: /* IVB */
case 0x3D: /* IVB Xeon */
return 1;
}
return 0;
Expand Down

0 comments on commit 650a37f

Please sign in to comment.