Skip to content

Commit

Permalink
Merge pull request moby#4160 from crosbymichael/cleanup-exec-drivers
Browse files Browse the repository at this point in the history
Cleanup some statements from exec driver work
  • Loading branch information
vieux committed Feb 15, 2014
2 parents 072268a + 9e3da87 commit a7ecc3e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 22 deletions.
1 change: 0 additions & 1 deletion execdriver/lxc/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ func changeUser(args *execdriver.InitArgs) error {
}

func setupCapabilities(args *execdriver.InitArgs) error {

if args.Privileged {
return nil
}
Expand Down
14 changes: 0 additions & 14 deletions runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"github.com/dotcloud/docker/dockerversion"
"github.com/dotcloud/docker/engine"
"github.com/dotcloud/docker/execdriver"
"github.com/dotcloud/docker/execdriver/chroot"
"github.com/dotcloud/docker/execdriver/lxc"
"github.com/dotcloud/docker/graphdriver"
"github.com/dotcloud/docker/graphdriver/aufs"
Expand Down Expand Up @@ -704,19 +703,6 @@ func NewRuntimeFromDirectory(config *DaemonConfig, eng *engine.Engine) (*Runtime

sysInfo := sysinfo.New(false)

/*
temporarilly disabled.
*/
if false {
var ed execdriver.Driver
if driver := os.Getenv("EXEC_DRIVER"); driver == "lxc" {
ed, err = lxc.NewDriver(config.Root, sysInfo.AppArmor)
} else {
ed, err = chroot.NewDriver()
}
if ed != nil {
}
}
ed, err := lxc.NewDriver(config.Root, sysInfo.AppArmor)
if err != nil {
return nil, err
Expand Down
8 changes: 1 addition & 7 deletions sysinit/sysinit.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,12 @@ func setupEnv(args *execdriver.InitArgs) {

func executeProgram(args *execdriver.InitArgs) error {
setupEnv(args)

dockerInitFct, err := execdriver.GetInitFunc(args.Driver)
if err != nil {
panic(err)
}
return dockerInitFct(args)

if args.Driver == "lxc" {
// Will never reach
} else if args.Driver == "chroot" {
}

return nil
}

// Sys Init code
Expand Down

0 comments on commit a7ecc3e

Please sign in to comment.