Add Docker install instructions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much - this is great! I reviewed your work, and have a few notes. I hope you're up for another round :) |
|
Sure, no problem. Did you already comment on some things, because I can't see it? |
chrivers
reviewed
Aug 23, 2024
|
Looking good! Do you mind rebasing on top of master? I like to keep the git history reasonably clean :) |
|
Hey, not at Home right now, so I'll have to do that later. I'm not very experienced with git and GitHub, do you mind pointing me in a direction on how to rebase / what you mean by that? |
Co-authored-by: Christian Iversen <[email protected]> Signed-off-by: ellwoodb <[email protected]>
Co-authored-by: Christian Iversen <[email protected]> Signed-off-by: ellwoodb <[email protected]>
|
Good news, I was able to rebase the branch from github :) Thanks for the work, I'll merge it 👍 |
|
Perfect, glad to have helped! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @chrivers, me again. Just got to writing some instructions for the Docker installation.
I tried to be as clear and simple as possible. I also tried to align the style to the rest of the
readme, hopefully that worked. I also quickly ran it through a spellcheck, but if you find anything wrong, feel free to edit it.Quick question: I saw there is a package now that we could use as an image. I haven't tried it yet, is it ready for me to add it to the
readmeanddocker-compose? For now, I wrote it with only having theDockerfileoption.If you encounter any problems, feel free to ask and make adjustments as you like.