Update installation instructions in the README #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I expanded the installation instructions in the README in order to address a few pain points I had while setting up badssl.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
lgarron
requested changes
Aug 26, 2017
README.md
Outdated
| cp gen/key/ca-root.key pregen/key/ca-root.key | ||
| 6. The badssl root certificate is at `certs/sets/test/gen/crt/ca-root.crt`. In order to get the rest of the badssl subdomains working, you will need to add this to your machine's list of trusted certificates. | ||
|
|
||
| ##### Mac OS X |
There was a problem hiding this comment.
Good idea! I moved it to a sub-bullet.
README.md
Outdated
| make list-hosts # list of domains to copy into /etc/hosts | ||
| 2. Clone into the badssl repo by running `git clone https://github.com/chromium/badssl.com && cd badssl.com`. | ||
|
|
||
| 3. In order to access the various badssl subdomains locally you will need to add them to your [system hosts file](http://bencane.com/2013/10/29/managing-dns-locally-with-etchosts/). Run `make list-hosts` and copy and paste the output into `/etc/hosts`. |
There was a problem hiding this comment.
Nit: link to HTTPS version of that page. ;-)
- Changed a http link -> https - Move the macOS X root certificate instructions to a sub bullet
sashaperigo
commented
Aug 26, 2017
README.md
Outdated
| make list-hosts # list of domains to copy into /etc/hosts | ||
| 2. Clone into the badssl repo by running `git clone https://github.com/chromium/badssl.com && cd badssl.com`. | ||
|
|
||
| 3. In order to access the various badssl subdomains locally you will need to add them to your [system hosts file](http://bencane.com/2013/10/29/managing-dns-locally-with-etchosts/). Run `make list-hosts` and copy and paste the output into `/etc/hosts`. |
README.md
Outdated
| cp gen/key/ca-root.key pregen/key/ca-root.key | ||
| 6. The badssl root certificate is at `certs/sets/test/gen/crt/ca-root.crt`. In order to get the rest of the badssl subdomains working, you will need to add this to your machine's list of trusted certificates. | ||
|
|
||
| ##### Mac OS X |
There was a problem hiding this comment.
Good idea! I moved it to a sub-bullet.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expanded the installation instructions in the README in order to address a few pain points I had while setting up badssl.