Skip to content

Commit

Permalink
Bucket aggregation getBuckets() should be public. (searchbox-io#630)
Browse files Browse the repository at this point in the history
Otherwise, if you're desigining APIs that work with any BucketAggregation subclass, you don't have a way without using things like reflection to get the buckets, keys, and counts regardless of specific aggregation type.

Signed-off-by: John Dimeo <[email protected]>
  • Loading branch information
jdimeo authored and ferhatsb committed Jul 16, 2019
1 parent b62c507 commit debfca8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ public BucketAggregation(String name, JsonObject root) {
super(name, root);
}

abstract List<? extends Bucket> getBuckets();
public abstract List<? extends Bucket> getBuckets();
}

0 comments on commit debfca8

Please sign in to comment.