better use of const

chungtlai · Jan 7, 2014 · 6369640 · 6369640
1 parent e59dcf3
commit 6369640
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/web/model/cell.dart b/web/model/cell.dart
@@ -15,10 +15,10 @@ class Cell extends Object with Observable {
 }
 
 class CellPoint {
-  int row;
-  int col;
+  final int row;
+  final int col;
 
-  CellPoint(int this.row, int this.col);
+  const CellPoint(int this.row, int this.col);
 
   String toString() => "row: $row, col: $col";
 }
diff --git a/web/views/main/main_view.dart b/web/views/main/main_view.dart
@@ -24,15 +24,15 @@ class MainView extends PolymerElement {
   int turnCount;
 
   // win patterns
-  final List<List<CellPoint>> winPatterns = [
-    [new CellPoint(0, 0), new CellPoint(0, 1), new CellPoint(0, 2)],  // row 1
-    [new CellPoint(1, 0), new CellPoint(1, 1), new CellPoint(1, 2)],  // row 2
-    [new CellPoint(2, 0), new CellPoint(2, 1), new CellPoint(2, 2)],  // row 3
-    [new CellPoint(0, 0), new CellPoint(1, 0), new CellPoint(2, 0)],  // col 1
-    [new CellPoint(0, 1), new CellPoint(1, 1), new CellPoint(2, 1)],  // col 2
-    [new CellPoint(0, 2), new CellPoint(1, 2), new CellPoint(2, 2)],  // col 3
-    [new CellPoint(0, 0), new CellPoint(1, 1), new CellPoint(2, 2)],  // diag 1
-    [new CellPoint(0, 2), new CellPoint(1, 1), new CellPoint(2, 0)]   // diag 2
+  final List<List<CellPoint>> winPatterns = const [
+    const [const CellPoint(0, 0), const CellPoint(0, 1), const CellPoint(0, 2)],  // row 1
+    const [const CellPoint(1, 0), const CellPoint(1, 1), const CellPoint(1, 2)],  // row 2
+    const [const CellPoint(2, 0), const CellPoint(2, 1), const CellPoint(2, 2)],  // row 3
+    const [const CellPoint(0, 0), const CellPoint(1, 0), const CellPoint(2, 0)],  // col 1
+    const [const CellPoint(0, 1), const CellPoint(1, 1), const CellPoint(2, 1)],  // col 2
+    const [const CellPoint(0, 2), const CellPoint(1, 2), const CellPoint(2, 2)],  // col 3
+    const [const CellPoint(0, 0), const CellPoint(1, 1), const CellPoint(2, 2)],  // diag 1
+    const [const CellPoint(0, 2), const CellPoint(1, 1), const CellPoint(2, 0)]   // diag 2
   ];
 
   // UI data